Update CLI logic to use Cmdliner-recommended style#1558
Merged
Conversation
nhuurre
approved these changes
Oct 10, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
- Coverage 90.26% 90.26% -0.01%
==========================================
Files 64 64
Lines 9916 9929 +13
==========================================
+ Hits 8951 8962 +11
- Misses 965 967 +2
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Cmdliner's docs:
This moves the stanc.exe driver code in that direction. Where we were before relying on
Cmd.eval_value', we now can just useCmd.eval', and we can treat exit codes like more of a first class citizen without as much matching on cmdliner's internal return types.Submission Checklist
Release notes
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)