Shim PR to handle change to is_autodiff#1554
Closed
SteveBronder wants to merge 2 commits intomasterfrom
Closed
Conversation
Contributor
Author
|
Srry need to close this. My local copy of stanc3 is behind in some odd ways and it's easier to make a branch |
Member
|
@SteveBronder let me know if it’s easier for me to just make the change, looks straightforward enough |
Contributor
Author
|
Sure if you don't mind! It looks like my local opam is bonked in some weird way and I probably have to delete and reinstall the whole thing |
Member
|
@SteveBronder -- just a guess, but try |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Release notes
This changes from using
is_autodifftois_fvar<T> | is_var<T>in the requires for user defined functions. Once stan-dev/math#3240 is merged we can just change tois_autodiff_scalar.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)