Update parser error messages for consistent style, tone#1549
Merged
Update parser error messages for consistent style, tone#1549
Conversation
nhuurre
approved these changes
Sep 12, 2025
Collaborator
nhuurre
left a comment
nhuurre
left a comment
There was a problem hiding this comment.
TLDR I mean LGTM
These messages are mostly like
Ill-formed compound assignment statement. Expected a ";" after the value being assigned.
but a few are like
Ill-formed declaration. ";" expected after variable declaration.
For more consistent style the latter could be
Ill-formed declaration. Expected ";" after variable declaration.
(but this might not be always better.)
This was referenced Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few consistency edits:
Also:
parser.messagesSubmission Checklist
Release notes
Improved the wording of syntax error messages.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)