Update size codegen to reduce bracket depth as number of parameters grows#1542
Merged
Update size codegen to reduce bracket depth as number of parameters grows#1542
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1542 +/- ##
==========================================
- Coverage 90.25% 90.24% -0.02%
==========================================
Files 64 64
Lines 9914 9914
==========================================
- Hits 8948 8947 -1
- Misses 966 967 +1
🚀 New features to boost your workflow:
|
nhuurre
reviewed
Sep 24, 2025
nhuurre
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current codegen has occasionally lead to issues for clang users who use BRMS and end up with a lot of parameters. We were already using very similar logic elsewhere that didn't generate a ton of extra parenthesis, so I just made them use the same logic.
Submission Checklist
Release notes
The C++ generated by models with many individually named parameters should be less likely to produce errors complaining about
bracket depth exceededCopyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)