Generate forward_as_tuple for tuple expressions, fully template tuple functions#1535
Merged
Generate forward_as_tuple for tuple expressions, fully template tuple functions#1535
Conversation
3 tasks
WardBrian
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1535 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 66 66
Lines 9890 9890
=======================================
Hits 8878 8878
Misses 1012 1012
🚀 New features to boost your workflow:
|
Member
Author
|
Think I've got it now |
|
Cool, thanks @WardBrian. If you like (and github builds the stanc executable) I could try whether this runs with the original model, which is slightly more complex than the MWE. |
Member
Author
|
I can try that and report back if it helps! We've for now moved to the serial implementation, which works well enough for now for us :) |
26 tasks
SteveBronder
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes both #1534 and #1532.
Submission Checklist
Release notes
Updated code generation of tuples to avoid issues with dangling references and some generated code being uncompilable.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)