Laplace: also check into index expressions for incompatibilities. #1516
Merged
Laplace: also check into index expressions for incompatibilities. #1516
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1516 +/- ##
=======================================
Coverage 89.81% 89.81%
=======================================
Files 66 66
Lines 9886 9887 +1
=======================================
+ Hits 8879 8880 +1
Misses 1007 1007
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow on to #1513. I realized that when combined with really esoteric functions like
int_stepor the size functions, one might be able to smuggle higher-order-incompatible functions into the expression of an lvalue index, which we were not previously checking.Note that I could not actually get an example where the C++ failed to compile after a couple tries, but it seems best to prevent these anyway for now.
Submission Checklist
Release notes
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)