Remove usages of re, clean up libraries fields in dune#1489
Remove usages of re, clean up libraries fields in dune#1489
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1489 +/- ##
==========================================
+ Coverage 90.07% 90.45% +0.38%
==========================================
Files 66 66
Lines 10759 10706 -53
==========================================
- Hits 9691 9684 -7
+ Misses 1068 1022 -46
|
| | LTupleProjection (lv1, idx1), LTupleProjection (lv2, idx2) -> | ||
| let idx_comp = Int.compare idx1 idx2 in | ||
| if idx_comp = 0 then compare_no_indexing lv1 lv2 else idx_comp |
There was a problem hiding this comment.
This was a "fun" one I realized after getting a build on 5.3.0, which is as previously implemented the sort here could actually be non-transitive, which led to a newly-optimized version of the List.find_all_dups function to miss some duplicates and allow an existing bad test to instead compile
There was a problem hiding this comment.
It's reassuring to know that our test coverage is wide enough to catch even such subtle bugs.
There was a problem hiding this comment.
That's certainly true -- it was painful to debug, but would have been much worse to not know about it at all
2 participants
This started with me testing building the compiler under OCaml 5.3.0. After installing the most recent version of our dependencies, the build was still failing, because
rewasn't installed. It turns out, it's no longer in the Jane Street dependency tree in the next version (0.17.x)I then realized we were not documenting this dependency anywhere, and it's also completely unnecessary based on its usages. So I pulled it out, and then updated the dune files to not request linking it. It turns out that the
strlibrary we were listing was also just requesting a link to our own alias ofmodule Str = Re.Str, which was... messy, to say the least!Submission Checklist
Release notes
Removed usages of the
relibraryCopyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)