Skip to content

Expose beta_neg_binomial_lpmf#1452

Merged
WardBrian merged 3 commits intomasterfrom
feature/beta_neg_binomial_lpmf
Oct 7, 2024
Merged

Expose beta_neg_binomial_lpmf#1452
WardBrian merged 3 commits intomasterfrom
feature/beta_neg_binomial_lpmf

Conversation

@WardBrian
Copy link
Copy Markdown
Member

From stan-dev/math#3108 (ping @lingium)

Submission Checklist

  • Run unit tests
  • Documentation
    • If a user-facing facing change was made, the documentation PR is here:

Release notes

Exposed new distribution beta_neg_binomial

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@WardBrian WardBrian added the feature New feature or request label Oct 2, 2024
@WardBrian WardBrian requested a review from SteveBronder October 2, 2024 15:55
@WardBrian
Copy link
Copy Markdown
Member Author

@SteveBronder I couldn't tell if these signatures supported SoA or not -- do they?

@WardBrian
Copy link
Copy Markdown
Member Author

@serban-nicusor-toptal this is getting an odd error in the expression tests, can you take a look? It looks like something isn't being deleted properly between runs

@SteveBronder
Copy link
Copy Markdown
Contributor

Yes how it's written it should

@WardBrian
Copy link
Copy Markdown
Member Author

This is now passing, mind approving @SteveBronder?

@lingium The next step is documenting the distribution for users at https://github.com/stan-dev/docs/tree/master/src/functions-reference -- would you mind giving that a go?

@lingium
Copy link
Copy Markdown

lingium commented Oct 4, 2024

@WardBrian Sure, I can take care of that

@WardBrian WardBrian merged commit 1931ba6 into master Oct 7, 2024
@WardBrian WardBrian deleted the feature/beta_neg_binomial_lpmf branch October 7, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants