Allow #include statements to function in stanc.js#1432
Closed
Allow #include statements to function in stanc.js#1432
#include statements to function in stanc.js#1432Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1432 +/- ##
==========================================
- Coverage 89.83% 89.75% -0.08%
==========================================
Files 63 65 +2
Lines 10484 10495 +11
==========================================
+ Hits 9418 9420 +2
- Misses 1066 1075 +9
|
3 tasks
Member
Author
|
Superseded by #1433 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1430
This PR can be viewed as several parts:
{ [s: string] : string }JS object into a ocamlstring String.Map.tAn earlier version of this didn't use functors and just had
Preprocessorstore a function pointer that was set by stancjs.ml/stanc.ml, but I had both aesthetic and performance concerns with that approach. These functors are ultimately pretty lightweightThis is currently lightly tested in stanc.js but I intend to add more.
Submission Checklist
Release notes
stanc.jscan now accept models which contain#includestatements. A fourth argument is available on the javascriptstancfunction which must be eitherundefinedor a object mapping included file names to Stan source code as strings.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)