@andrjohns can you give this a once over?

@serban-nicusor-toptal I think we should edit a file in src/ to trigger a build artificially. Maybe just edit a comment in src/stanc/stan.ml by adding or deleting a newline or something

Nothing stands out to me, so no complaints from my end

Just a question, really, because I don’t understand docker that well: would it save time to build the docket instances we use once and upload them in the same place? It seems like we’re always rebuilding the Windows instance for example

Once we had the images transferred I was also going to suggest building the other images rather than using dockerfiles. The Opam setup and dependencies definitely takes far longer than downloading the image. So +1 from me on that suggestion

Glad my suggestion wasn’t too crazy. We will need to rebuild the images if/when we update OCaml and our dependencies, but I think that’s more like a once every couple years problem

I'll build and push the rest to stanorg.
Does it make any sense to set up and CI to build the images when there are changes to dockerfile/windows for example? I would do it so we have less to worry about.

If we’re building the images would we still want to maintain a docker folder here? I think just the scripts would be enough them?

I would say we need it as it defines the build steps of the docker build process, else I would either separate them into another repo or template them on the fly.

Feels like they could live in the ci-scripts repo if we moved to that system. It can be a separate PR though

debian and debian-windows pushed to Docker Hub.
If these images are used only in the CI, we can surely move them to ci-scripts ( will do another PR ).

Great!

The follow on PR can also remove the comment in stanc.ml which is great.

Any merit to leaving that comment in during the merge to test all the non-x86 binaries?

Well we can do it to be extra sure that everything works right after the merge. Do we remove it later in a PR ?
Also, is there something else needed for this PR ?

If we're doing a follow on PR to remove the dockerfiles (them being moved to ci-scripts) we can remove it then, yes. Otherwise this seems good to me.