Merge pull request #1540 from stan-dev/fix/mislabeled-scalar-functions-SoA

WardBrian · web-flow · commit 03f4ea617472 · 2025-08-15T19:08:38.000-04:00
Fix some scalar functions being mislabeled as SoA
diff --git a/src/stan_math_signatures/Generate.ml b/src/stan_math_signatures/Generate.ml
@@ -270,7 +270,7 @@ let distributions =
   ; (full_lpdf, "rayleigh", [DVReal; DVReal], SoA)
   ; (full_lpdf, "scaled_inv_chi_square", [DVReal; DVReal; DVReal], SoA)
   ; (full_lpdf, "skew_normal", [DVReal; DVReal; DVReal; DVReal], SoA)
-  ; (full_lpdf, "skew_double_exponential", [DVReal; DVReal; DVReal; DVReal], SoA)
+  ; (full_lpdf, "skew_double_exponential", [DVReal; DVReal; DVReal; DVReal], AoS)
   ; (full_lpdf, "student_t", [DVReal; DVReal; DVReal; DVReal], SoA)
   ; (full_lpdf, "std_normal", [DVReal], SoA)
   ; (full_lpdf, "uniform", [DVReal; DVReal; DVReal], SoA)
@@ -344,7 +344,7 @@ let math_sigs =
   ; ([UnaryVectorized SameAsArg], "minus", [DDeepComplexVectorized], SoA)
   ; ([basic_vectorized], "Phi", [DDeepVectorized], SoA)
   ; ([basic_vectorized], "Phi_approx", [DDeepVectorized], SoA)
-  ; ([basic_vectorized], "round", [DDeepVectorized], SoA)
+  ; ([basic_vectorized], "round", [DDeepVectorized], AoS)
   ; ([basic_vectorized], "sin", [DDeepVectorized], SoA)
   ; ([basic_vectorized], "sinh", [DDeepVectorized], SoA)
   ; ([basic_vectorized], "sqrt", [DDeepVectorized], SoA)
@@ -353,12 +353,12 @@ let math_sigs =
   ; ([basic_vectorized], "std_normal_qf", [DDeepVectorized], SoA)
     (* std_normal_qf is an alias for inv_Phi *)
   ; ([basic_vectorized], "std_normal_log_qf", [DDeepVectorized], SoA)
-  ; ([basic_vectorized], "step", [DReal], SoA)
+  ; ([basic_vectorized], "step", [DReal], AoS)
   ; ([basic_vectorized], "tan", [DDeepVectorized], SoA)
   ; ([basic_vectorized], "tanh", [DDeepVectorized], SoA)
   ; ([basic_vectorized], "tgamma", [DDeepVectorized], SoA)
-  ; ([basic_vectorized], "trunc", [DDeepVectorized], SoA)
-  ; ([basic_vectorized], "trigamma", [DDeepVectorized], SoA) ]
+  ; ([basic_vectorized], "trunc", [DDeepVectorized], AoS)
+  ; ([basic_vectorized], "trigamma", [DDeepVectorized], AoS) ]
 
 let all_declarative_sigs = distributions @ math_sigs
 
diff --git a/test/integration/good/compiler-optimizations/cppO0.expected b/test/integration/good/compiler-optimizations/cppO0.expected
@@ -14908,7 +14908,7 @@ static constexpr std::array<const char*, 8> locations_array__ =
   " (in 'initialize-SoA.stan', line 6, column 2 to column 25)",
   " (in 'initialize-SoA.stan', line 9, column 2 to column 19)",
   " (in 'initialize-SoA.stan', line 11, column 4 to column 30)",
-  " (in 'initialize-SoA.stan', line 10, column 17 to line 12, column 3)",
+  " (in 'initialize-SoA.stan', line 10, column 19 to line 12, column 3)",
   " (in 'initialize-SoA.stan', line 10, column 2 to line 12, column 3)"};
 class initialize_SoA_model final : public model_base_crtp<initialize_SoA_model> {
  private:
diff --git a/test/integration/good/compiler-optimizations/cppO1.expected b/test/integration/good/compiler-optimizations/cppO1.expected
@@ -16194,7 +16194,7 @@ static constexpr std::array<const char*, 8> locations_array__ =
   " (in 'initialize-SoA.stan', line 6, column 2 to column 25)",
   " (in 'initialize-SoA.stan', line 9, column 2 to column 19)",
   " (in 'initialize-SoA.stan', line 11, column 4 to column 30)",
-  " (in 'initialize-SoA.stan', line 10, column 17 to line 12, column 3)",
+  " (in 'initialize-SoA.stan', line 10, column 19 to line 12, column 3)",
   " (in 'initialize-SoA.stan', line 10, column 2 to line 12, column 3)"};
 class initialize_SoA_model final : public model_base_crtp<initialize_SoA_model> {
  private:
diff --git a/test/integration/good/compiler-optimizations/initialize-SoA.stan b/test/integration/good/compiler-optimizations/initialize-SoA.stan
@@ -7,7 +7,7 @@ transformed parameters {
 }
 model {
   x ~ std_normal();
-  for (i in 1:3) {
+  for (i in 1 : 3) {
     arr_vec[i] ~ std_normal();
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ transformed parameters {`
`7`	`7`	`}`
`8`	`8`	`model {`
`9`	`9`	`x ~ std_normal();`
`10`		`- for (i in 1:3) {`
	`10`	`+ for (i in 1 : 3) {`
`11`	`11`	`arr_vec[i] ~ std_normal();`
`12`	`12`	`}`
`13`	`13`	`}`