Skip to content

[helm] Add templating support for additionals labels #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msafwankarim merged 2 commits into from
Jul 2, 2025
Merged

[helm] Add templating support for additionals labels #938

msafwankarim merged 2 commits into from
Jul 2, 2025

Conversation

@vmizoules
Copy link

@vmizoules vmizoules commented Jun 16, 2025 •
edited
Loading

Everything is in the title ⬆️

It's aligned with what has been done in this commit for the ServiceMonitor: 1f2d758

Goal is to support values with helm-template inside, like:

reloader:
  deployment:
    labels:
      anotherChartLabel: 'the chart name is {{ .Chart.Name }}'

To have the label rendered in the manifest:

    labels:
      [...]
      anotherChartLabel: the chart name is reloader

Regards

@vmizoules vmizoules marked this pull request as ready for review June 16, 2025 15:48
msafwankarim
msafwankarim approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@msafwankarim msafwankarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission. Let's get this merged

@msafwankarim msafwankarim merged commit 0ff6d0f into stakater:master Jul 2, 2025
2 checks passed
pratikbin pushed a commit to NodeOps-app/Reloader that referenced this pull request Nov 13, 2025
@msafwankarim
Merge pull request stakater#938 from vmizoules/feat(chart)_allow_temp…
69361c9 
…lating_labels

[helm] Add templating support for additionals labels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msafwankarim msafwankarim msafwankarim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmizoules @msafwankarim