Skip to content

feat: support Google Chat as an Alert notification provider #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
msafwankarim merged 3 commits into from
Jul 3, 2025
Merged

feat: support Google Chat as an Alert notification provider #934

msafwankarim merged 3 commits into from
Jul 3, 2025

Conversation

@alexandermarston
Copy link
Contributor

@alexandermarston alexandermarston commented Jun 10, 2025

This MR adds support for Google Chat as an alternate webhook provider, for sending reloader alerts.

msafwankarim
msafwankarim reviewed Jul 2, 2025
View reviewed changes
Copy link
Contributor

@msafwankarim msafwankarim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for your PR submission. As we have no automated tests for alerts, please confirm whether this new function has been manually tested or not?

@alexandermarston
Copy link
Contributor Author

alexandermarston commented Jul 2, 2025

Hi! Thanks for your PR submission. As we have no automated tests for alerts, please confirm whether this new function has been manually tested or not?

Thanks - this has been tested.

Screenshot 2025-07-02 at 15 52 44

msafwankarim
msafwankarim approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@msafwankarim msafwankarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! There is an issue with the pipeline on our end. We will get this PR merged as soon as it is fixed.

@msafwankarim
Copy link
Contributor

msafwankarim commented Jul 3, 2025

Please rebase onto the latest main to bring in the updated workflow configuration.

@alexandermarston
Copy link
Contributor Author

alexandermarston commented Jul 3, 2025

Please rebase onto the latest main to bring in the updated workflow configuration.

Thanks. I've pulled in the latest changes, but still some failing jobs. Maybe it's a permission thing.

@msafwankarim
Copy link
Contributor

msafwankarim commented Jul 3, 2025

Thanks. I've pulled in the latest changes, but still some failing jobs. Maybe it's a permission thing.

Yes it requires some secrets that are not set in case of forks. We pushed a fix you'll have to rebase it again. Sorry for inconvenience

@msafwankarim msafwankarim merged commit 516f9e8 into stakater:master Jul 3, 2025
10 checks passed
@alexandermarston alexandermarston deleted the support-gchat branch July 3, 2025 11:29
@renovate renovate bot mentioned this pull request Jul 24, 2025
Open
1 task
pratikbin pushed a commit to NodeOps-app/Reloader that referenced this pull request Nov 13, 2025
@msafwankarim
Merge pull request stakater#934 from alexandermarston/support-gchat
6e9d8ce 
feat: support Google Chat as an Alert notification provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msafwankarim msafwankarim msafwankarim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexandermarston @msafwankarim