Ignore namespaceSelector when not watch globally #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdelucaa
reviewed
Jun 26, 2025
msafwankarim
approved these changes
Jul 11, 2025
pratikbin
pushed a commit
to NodeOps-app/Reloader
that referenced
this pull request
Nov 13, 2025
Ignore namespaceSelector when not watch globally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
Kubernetes
Namespaceis a cluster-scoped resource, not a namespaced one.As such, it cannot be managed via
Role, which only applies to namespaced resources.To perform operations on
Namespace(e.g.,get,list), you must use aClusterRolewith aClusterRoleBinding.Using a Role alone will not grant any permission on namespaces—including read/search access.
Issue list
Fixes #862
Fixes #893