Skip to content

Conversation

@kvandenhoute
Copy link
Contributor

Add support for cronjob triggers to Stakater.

On change of configmap/secret a job is created from a job

@jkurek1
Copy link

jkurek1 commented Jul 12, 2023

Hi @kvandenhoute,
It is really good feature. I have use case with Knative Services: #493
Using that approach CronJob can add annotations to Service.

It would be really good to have it.

@github-actions
Copy link

@MuneebAijaz Image is available for testing. docker pull ghcr.io/:SNAPSHOT-PR-486-5e7f1302

@github-actions
Copy link

@karl-johan-grahn Image is available for testing. docker pull ghcr.io/:SNAPSHOT-PR-486-3e7cc40c

@bnallapeta bnallapeta self-requested a review August 9, 2023 08:27
Copy link

@bnallapeta bnallapeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall PR looks good except for the minor changes requested.

@stgrace
Copy link
Contributor

stgrace commented Sep 29, 2023

@bnallapeta All requested changes should be fixed now

@github-actions
Copy link

@stgrace Image is available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-486-4dfd0e51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants