Fix SHA for multipart upload (#480)

aprendendofelipe · web-flow · commit 259363866871 · 2026-03-14T23:00:26.000+03:30
diff --git a/packages/app/server/routes/multipart/create.post.ts b/packages/app/server/routes/multipart/create.post.ts
@@ -1,8 +1,12 @@
-import { isWhitelisted } from "@pkg-pr-new/utils";
+import { isValidGitHash, isWhitelisted } from "@pkg-pr-new/utils";
 import { joinKeys } from "unstorage";
 
 export default eventHandler(async (event) => {
-  const { "sb-key": workflowKey, "sb-name": packageName } = getHeaders(event);
+  const {
+    "sb-key": workflowKey,
+    "sb-name": packageName,
+    "sb-sha": shaOverride,
+  } = getHeaders(event);
 
   if (!workflowKey) {
     throw createError({
@@ -35,6 +39,16 @@ export default eventHandler(async (event) => {
     });
   }
 
+  if (shaOverride) {
+    if (!isValidGitHash(shaOverride)) {
+      throw createError({
+        statusCode: 400,
+        message: "Invalid sb-sha: must be a valid hexadecimal SHA",
+      });
+    }
+    workflowData.sha = shaOverride;
+  }
+
   const binding = useBinding(event);
 
   const base = `${workflowData.owner}:${workflowData.repo}:${workflowData.sha}`;
diff --git a/packages/app/server/routes/publish.post.ts b/packages/app/server/routes/publish.post.ts
@@ -63,7 +63,7 @@ export default eventHandler(async (event) => {
       if (!isValidGitHash(shaOverride)) {
         throw createError({
           statusCode: 400,
-          message: "Invalid sb-sha: must be a 40-character hex SHA",
+          message: "Invalid sb-sha: must be a valid hexadecimal SHA",
         });
       }
       workflowData.sha = shaOverride;
diff --git a/packages/cli/index.ts b/packages/cli/index.ts
@@ -528,6 +528,7 @@ const main = defineCommand({
                   headers: {
                     "sb-key": key,
                     "sb-name": name.slice("package:".length),
+                    "sb-sha": sha,
                   },
                 });
                 if (!createMultipartRes.ok) {

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ export default eventHandler(async (event) => {`
`63`	`63`	`if (!isValidGitHash(shaOverride)) {`
`64`	`64`	`throw createError({`
`65`	`65`	`statusCode: 400,`
`66`		`- message: "Invalid sb-sha: must be a 40-character hex SHA",`
	`66`	`+ message: "Invalid sb-sha: must be a valid hexadecimal SHA",`
`67`	`67`	`});`
`68`	`68`	`}`
`69`	`69`	`workflowData.sha = shaOverride;`