Skip to content

ci(template): Use nightly toolchain for rustfmt job #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Apr 2, 2025

Currently, the rustfmt job uses the stable toolchain, which doesn't support various rustfmt options. This came up during the rollout of #495.

@Techassi Techassi self-assigned this Apr 2, 2025
@Techassi Techassi moved this to Development: In Progress in Stackable Engineering Apr 2, 2025
@Techassi Techassi force-pushed the template/ci-nightly-toolchain-rustfmt branch from 7f85214 to 5768e89 Compare April 2, 2025 14:39
@Techassi Techassi moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Apr 2, 2025
@Techassi
Copy link
Member Author

Techassi commented Apr 2, 2025

Note to self: The workflows should also be refactored. We again do a whole bunch of duplicate (and slightly incorrect) checks.

@NickLarsenNZ NickLarsenNZ moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 2, 2025
@NickLarsenNZ NickLarsenNZ self-requested a review April 2, 2025 14:47
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Apr 2, 2025
@Techassi Techassi moved this from Development: In Review to Development: Done in Stackable Engineering Apr 2, 2025
Merged via the queue into main with commit f1f1a9e Apr 2, 2025
2 checks passed
@Techassi Techassi deleted the template/ci-nightly-toolchain-rustfmt branch April 2, 2025 14:51
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants