Merged
Conversation
4 tasks
jbants
approved these changes
Apr 23, 2021
jbants
left a comment
jbants
left a comment
There was a problem hiding this comment.
Question about version bump for the extension otherwise looks good.
This was referenced Apr 26, 2021
cholmes
approved these changes
Apr 26, 2021
Contributor
Author
|
I applied couple of additional improvements based on this schema in data cube, which is now pioneering the changes in a release: stac-extensions/datacube@50e9f91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema for collections has an issue that comes up once you don't use sci: fields top-level in collections. This is an attempt to fix this issue.
This likely needs an alignment for all extensions and a change in the template.
This PR needs to be released as 1.0.1 for radiantearth/stac-spec#1093 to work.
Haven't had the time yet to check in detail whether all my changes work properly, but added more examples to test against.
Issue will always be that we don't have json-schema-org/json-schema-spec#1077 yet, so validation in Collections will be not very strict/reliable anyway.