Summary

When using a Japanese (or other CJK) IME in the workflow creation popup, pressing Enter to confirm a conversion candidate was also triggering workflow submission. This happened because the Enter key handlers in NewWorkspaceComposerModal and NewWorkspacePage checked only event.key === 'Enter' without guarding against event.isComposing.

This PR extracts a pure helper shouldSuppressEnterSubmit() in new-workspace-enter-guard.ts and applies it at every submit-on-Enter site:

Fixes #742.

Screenshots

before fix

after fix

Testing

• pnpm lint
• pnpm typecheck
• pnpm test
• pnpm build
• Added or updated high-quality tests that would catch regressions, or explained why tests were not needed
• When confirming a Japanese IME conversion candidate with Enter, the workflow should not be submitted.

Unit tests added in new-workspace-enter-guard.test.ts covering:

• Plain Enter with no composition → not suppressed
• Enter while isComposing: true → suppressed
• Shift+Enter inside a textarea → suppressed
• Shift+Enter inside a non-textarea → not suppressed
• Both isComposing and Shift+Enter in a textarea → suppressed

AI Review Report

Reviewed with Claude Code. Main risks checked:

• Correctness of isComposing semantics: KeyboardEvent.isComposing is true from compositionstart until after compositionend. This means the Enter that fires immediately after the final compositionend may still carry isComposing: true in some browser/OS combinations (notably older Chrome on macOS). This is the standard recommendation from MDN and is the same guard used widely in web apps for this pattern.
• React SyntheticEvent gap: React.KeyboardEvent does not expose isComposing. The handleTaskSearchKeyDown handler correctly reads event.nativeEvent.isComposing to reach the underlying DOM event.
• Cross-platform compatibility: KeyboardEvent.isComposing is supported on all modern browsers across macOS, Linux, and Windows. No platform-specific shortcuts, labels, file paths, or Electron IPC are touched by this change. The fix applies equally to all IME users regardless of platform.
• Shift+Enter preservation: The existing Shift+Enter newline behavior in textarea is preserved — shouldSuppressEnterSubmit continues to block Shift+Enter in textareas.

No issues flagged requiring changes beyond what is already in this PR.

Security Audit

• No user input is executed, eval'd, or passed to a shell.
• No file paths, auth tokens, or secrets are handled.
• No IPC calls are added or modified.
• The change is a pure event-handler guard with no network or process interaction.

No security risks identified.

Notes

• The isComposing property is read from the native DOM event for React synthetic events — this is the correct and documented approach.
• Behavior verified manually with Japanese IME on macOS in the workflow creation popup.

X Account

https://x.com/w_q_r_q