Add unbound workspace delete shortcut#3875
Merged
nwparker merged 1 commit intoMay 30, 2026
Merged
Conversation
nwparker
force-pushed
the
nwparker/https-github.com-stablyai-orca-issues-2808
branch
from
May 30, 2026 19:52
f9fd22f to
ecf6272
Compare
This was referenced May 30, 2026
thomaszdxsn
pushed a commit
to thomaszdxsn/orca
that referenced
this pull request
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workspace.deletekeybinding action that can be customized without assigning a default chord yetDelete Workspaceaction that reuses the existing workspace delete confirmation flowCloses #2808
Test plan
pnpm vitest run --config config/vitest.config.ts src/shared/keybindings.test.ts src/shared/window-shortcut-policy.test.ts src/main/window/createMainWindow.test.ts src/renderer/src/components/cmd-j/quick-action-context.test.ts src/renderer/src/components/cmd-j/palette-results.test.tspnpm run typecheckpnpm vitest run --config config/vitest.config.ts src/renderer/src/hooks/useIpcEvents.test.ts src/renderer/src/web/web-preload-api.test.tspnpm run lintRisk: high
This introduces a workspace delete command path through keybindings, the main-window shortcut bridge, Cmd+J actions, preload, and renderer IPC. Even without a default chord, delete-workspace behavior is destructive and should get another review pass.