Skip to content

Notify worktree title rename mode from handlers#3298

Merged
nwparker merged 1 commit into
mainfrom
nwparker/react-perf-worktree-title-editing-change
May 29, 2026
Merged

Notify worktree title rename mode from handlers#3298
nwparker merged 1 commit into
mainfrom
nwparker/react-perf-worktree-title-editing-change

Conversation

@nwparker

Copy link
Copy Markdown
Contributor

Summary

  • Replace the inline worktree-title editing-change Effect with explicit rename-mode transitions
  • Notify the parent card in the same event turn so drag/styling disables without a delayed commit
  • Remove one local UI coordination Effect from the sidebar rename control

Risk: Low

Low because this is isolated local card/input UI state. It does not touch persistence, IPC, terminal, browser, source-control, SSH, or provider behavior.

Verification

  • pnpm exec oxfmt --write src/renderer/src/components/sidebar/WorktreeTitleInlineRename.tsx
  • pnpm exec oxlint src/renderer/src/components/sidebar/WorktreeTitleInlineRename.tsx
  • pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/sidebar/WorktreeTitleInlineRename.test.tsx
  • pnpm run typecheck:web
  • git diff --check
  • React Effect AST count: origin/main 912, branch 911

@nwparker
nwparker merged commit b38e701 into main May 29, 2026
2 checks passed
@nwparker
nwparker deleted the nwparker/react-perf-worktree-title-editing-change branch May 29, 2026 20:00
@nwparker nwparker added the risk:low Low risk change label May 30, 2026
thomaszdxsn pushed a commit to thomaszdxsn/orca that referenced this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Low risk change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant