Skip to content

Focus worktree rename input from ref#3296

Merged
nwparker merged 1 commit into
mainfrom
nwparker/react-perf-worktree-title-focus-ref
May 29, 2026
Merged

Focus worktree rename input from ref#3296
nwparker merged 1 commit into
mainfrom
nwparker/react-perf-worktree-title-focus-ref

Conversation

@nwparker

Copy link
Copy Markdown
Contributor

Summary

  • Replace the worktree title rename input focus Effect with a callback ref
  • Keep the one-keystroke select-all behavior when rename mode opens
  • Remove one visual-only Effect from the inline rename component

Risk: Low

Low because this is isolated local focus/selection behavior with no persistence, IPC, terminal, browser, source-control, SSH, or provider behavior.

Verification

  • pnpm exec oxfmt --write src/renderer/src/components/sidebar/WorktreeTitleInlineRename.tsx
  • pnpm exec oxlint src/renderer/src/components/sidebar/WorktreeTitleInlineRename.tsx
  • pnpm exec vitest run --config config/vitest.config.ts src/renderer/src/components/sidebar/WorktreeTitleInlineRename.test.tsx
  • pnpm run typecheck:web
  • git diff --check
  • React Effect AST count: origin/main 913, branch 912

@nwparker
nwparker merged commit fcd1c7e into main May 29, 2026
2 checks passed
@nwparker
nwparker deleted the nwparker/react-perf-worktree-title-focus-ref branch May 29, 2026 19:53
@nwparker nwparker added the risk:low Low risk change label May 30, 2026
thomaszdxsn pushed a commit to thomaszdxsn/orca that referenced this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Low risk change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant