Skip to content

[Bug]: Workflow creation popup submits on Japanese IME Enter confirmation #742

Description

@fffk10

Operating system

macOS

Orca version

1.2.2

Details

Summary

When using a Japanese IME in the workflow creation popup, confirming a composition with Enter submits the workflow instead of only committing the composed text.

The popup-wide Enter handler appears to submit whenever event.key === "Enter", but it does not guard against IME composition state such as event.isComposing.

MDN reference: https://developer.mozilla.org/ja/docs/Web/API/KeyboardEvent/isComposing

Steps to reproduce

  1. Open the workflow creation popup.
  2. Focus the prompt textarea or another text input in the popup.
  3. Enable a Japanese IME.
  4. Type text that requires composition.
  5. Press Enter to confirm the conversion candidate.

Expected behavior

Pressing Enter while IME composition is active should only confirm the conversion. The workflow should not be submitted until composition has finished and the user explicitly submits.

Actual behavior

The Enter key is treated as a submit action during IME confirmation, so the workflow is submitted unexpectedly.

output.mp4

Suspected cause

Both Enter handlers submit on event.key === "Enter" without checking composition state:

  • src/renderer/src/components/NewWorkspaceComposerModal.tsx
  • src/renderer/src/components/NewWorkspacePage.tsx

Suggested fix

Ignore Enter-based submit shortcuts while composition is active, for example by checking event.isComposing and/or the relevant native composition state before calling submit().

Impact

This makes the workflow creation UI unreliable for Japanese IME users and likely affects other IME users as well.

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingos:macosIssues affecting macOS

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions