Closed
Conversation
angerman
force-pushed
the
wip/make-build-pre-zig
branch
from
74fdffe to
a3d41c0
Compare
Author
|
This supersedes #4 |
11 tasks
We need Haskell anyway for GenSettings and Makefile syntax isn't high-level enough to write quality code.
… we should print the invocation that caused the failure.This would help a LOT when debugging.
the same fields were repeated over and over
- Avoid target variables to minimise hidden flow of information - Use ::group:: only on GitHub Actions - Use in-tree cabal by default as it is the only reasonable thing to do since the Cabal library will necessarily be the in-tree one. - Make the build directory relocatable - Remove some commented lines and unused variables - Added comments
… Hackage index This avoid unnecesary rebuilds.
…build Our cabal-install is now taking care of that. Leave a comment so we do not forget.
e.g. before we would not update ghc-bin.cabal when ghc-bin.cabal.in changed.
The check is too eager. For example, when compiling C sources the rts is not required.
This is not a real dependency. The real dependency is (transitively) on the rts main library. How the compiler fuitfil that dependency is an implementation detail.
andreabedini
force-pushed
the
wip/make-build-pre-zig
branch
from
62bf802 to
38e2200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds upon wip/make-build, and integrates some of the andrea/make-build parts.