This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Fix potential LRU cache size issue.#958
Merged
mcuadros merged 2 commits intosrc-d:masterfrom Sep 18, 2018
kuba--:fix-cachesize
Merged
Fix potential LRU cache size issue.#958mcuadros merged 2 commits intosrc-d:masterfrom kuba--:fix-cachesize
mcuadros merged 2 commits intosrc-d:masterfrom
kuba--:fix-cachesize
Conversation
Signed-off-by: kuba-- <[email protected]>
Signed-off-by: kuba-- <[email protected]>
mcuadros
requested review from
ajnavarro
and removed request for
a team and
smola
erizocosmico
approved these changes
Sep 18, 2018
ajnavarro
approved these changes
Sep 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- [email protected]
This PR fixes potential issue related to LRU Object/Buffer Cache size.
When you put to the cache the same object (key) but with different size,
actualSizeis not updating.