Fix host redirect handling#819
Conversation
|
I'm unable to sign the DCO because the sign-off process is weird, so feel free to consider this a bug report and and use the code as you wish. |
|
@DisposaBoy You just need to use You can also use Keep in mind that signing-off implies that you accept the DCO. |
|
@smola IMO, the whole process could be simplified to not require contributors to add their email address to commit messages and/or only do it once.
|
If you try to clone from a url that redirects to another host e.g. `example.com/repo` -> `github.com/org/repo.git`, it results in a redirect to `example.com/org/repo.git` because ModifyEndpointIfRedirect only takes into account the scheme and path. Signed-off-by: DisposaBoy <[email protected]>
|
@DisposaBoy Thanks for the clarification. I understand that contributing under a pseudonym is a very legitimate use case. But so far, we are not able to accept that under our current legal guidelines. I have moved this to an issue: #820 However, according to our present policy, I have to close this PR. |
If you try to clone from a url that redirects to another host e.g.
example.com/repo->github.com/org/repo.git, it results in a redirect toexample.com/org/repo.gitbecause ModifyEndpointIfRedirect only takes into account the scheme and path.