This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Conversation
- Use append instead of ranged for loop - Simpler bool comparison Signed-off-by: Christian Muehlhaeuser <[email protected]> (cherry picked from commit 3918d0e)
- Added missing error handling around encodeCommitData and prevented shadowing err. - Removed tautological error checks. Signed-off-by: Christian Muehlhaeuser <[email protected]> (cherry picked from commit 7d76176)
When we assign a value to err, make sure to also check for it being nil afterwards. If those were intentionally unchecked, we should remove the assignment in the first place. Those checks certainly never harm, but please review thoroughly and let me know. Signed-off-by: Christian Muehlhaeuser <[email protected]> (cherry picked from commit 19d6f42)
Signed-off-by: Christian Muehlhaeuser <[email protected]> (cherry picked from commit 047bb4f)
Just a bit easier to read, in my opinion. Signed-off-by: Christian Muehlhaeuser <[email protected]> (cherry picked from commit 91d314c)
No need to convert these values, they're already of the right type. Signed-off-by: Christian Muehlhaeuser <[email protected]> (cherry picked from commit a1d8a7a)
Since we don't check the value anyway, as it can't possibly be anything but nil. Signed-off-by: Christian Muehlhaeuser <[email protected]> (cherry picked from commit 293e70f)
Contributor
|
Thank you and sorry I didn't have the time to get around creating a new PR myself! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR's includes all the code quality improvements done by @muesli in several other PRs
Closes: #1182
Closes: #1183
Closes: #1184
Closes: #1185
Closes: #1186
Closes: #1187
Closes: #1188