This repository was archived by the owner on Sep 11, 2020. It is now read-only.
worktree: allow manual ignore patterns when no .gitignore is available#1070
Merged
mcuadros merged 2 commits intosrc-d:masterfrom Mar 4, 2019
Merged
worktree: allow manual ignore patterns when no .gitignore is available#1070mcuadros merged 2 commits intosrc-d:masterfrom
mcuadros merged 2 commits intosrc-d:masterfrom
Conversation
Contributor
|
Can you provide a test? |
Signed-off-by: Fabian Sabau <[email protected]>
Signed-off-by: Fabian Sabau <[email protected]>
fbsb
force-pushed
the
fix/enable-excluded-patterns
branch
from
2ecc89d to
b2e0af9
Compare
Contributor
Author
|
@mcuadros without the patch the test would fail when a .gitignore would not be present in the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using go-git as a library for a personal project and noticed hard-coded excluded patterns are ignored when no
.gitignorefile exists at the root of the repository.This PR fixes this behavior and allows hard-coded ignore patterns even when no
.gitignorefile is present