This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Ignore missing references/objects on log --all#1067
Merged
mcuadros merged 2 commits intosrc-d:masterfrom Feb 13, 2019
ajnavarro:fix/log-all-missing-objects
Merged
Ignore missing references/objects on log --all#1067mcuadros merged 2 commits intosrc-d:masterfrom ajnavarro:fix/log-all-missing-objects
mcuadros merged 2 commits intosrc-d:masterfrom
ajnavarro:fix/log-all-missing-objects
Conversation
kuba--
suggested changes
Feb 12, 2019
To mimic the actual standard git behavior, we must ignore references that are pointing to wrong/unexistent objects. Signed-off-by: Antonio Jesus Navarro Perez <[email protected]>
Signed-off-by: Antonio Jesus Navarro Perez <[email protected]>
Contributor
Author
|
@kuba-- done! and thanks for the tip! |
kuba--
approved these changes
Feb 13, 2019
Contributor
kuba--
left a comment
kuba--
left a comment
There was a problem hiding this comment.
LGTM, my only question is
does the logic in for loop is OK? Because it's slightly non-consistent what we have outside the loop. I mean:
- we break on
EOF - we skip
plumbing.ErrReferenceNotFound - we return on any other error
Contributor
Author
|
@kuba-- I think the logic is ok |
jfontan
approved these changes
Feb 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To mimic the actual standard git behavior, we must ignore references that are pointing to wrong/unexistent objects.
Signed-off-by: Antonio Jesus Navarro Perez [email protected]