Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

repository: Fix RefSpec for a single tag.#1015

Merged
mcuadros merged 1 commit intosrc-d:masterfrom
fkorotkov:fedor/fix-tag-clonning
Nov 7, 2018
Merged

repository: Fix RefSpec for a single tag.#1015
mcuadros merged 1 commit intosrc-d:masterfrom
fkorotkov:fedor/fix-tag-clonning

Conversation

@fkorotkov
Copy link
Copy Markdown
Contributor

@fkorotkov fkorotkov commented Nov 1, 2018 •
edited
Loading

Fixes #960

@fkorotkov fkorotkov mentioned this pull request Nov 1, 2018
Closed
@fkorotkov fkorotkov force-pushed the fedor/fix-tag-clonning branch 5 times, most recently from aa6e0d2 to 0410bf9 Compare November 6, 2018 17:00
@fkorotkov
Copy link
Copy Markdown
Contributor Author

fkorotkov commented Nov 6, 2018

@smola this PR is ready to be reviewed. Fixed failing tests 🙌

@mcuadros
Copy link
Copy Markdown
Contributor

mcuadros commented Nov 6, 2018

Can you provide a test? Thanks

@fkorotkov fkorotkov force-pushed the fedor/fix-tag-clonning branch from 0410bf9 to 3ab4ee5 Compare November 7, 2018 13:43
@fkorotkov
Copy link
Copy Markdown
Contributor Author

fkorotkov commented Nov 7, 2018

@mcuadros just added a test case which was failing before the change:

c.Assert(originRemote.Fetch[0].String(), Equals, "+refs/tags/commit-tag:refs/tags/commit-tag")
Expected :string = "+refs/tags/commit-tag:refs/tags/commit-tag"
Actual   :string = "+refs/heads/commit-tag:refs/remotes/origin/commit-tag"

@mcuadros mcuadros merged commit a779a26 into src-d:master Nov 7, 2018
@fkorotkov fkorotkov deleted the fedor/fix-tag-clonning branch November 7, 2018 15:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fkorotkov @mcuadros