Skip to content

Add Dockerfile - #12

Merged
smacker merged 1 commit into
src-d:masterfrom
smacker:docker
Jan 18, 2018
Merged

Add Dockerfile#12
smacker merged 1 commit into
src-d:masterfrom
smacker:docker

Conversation

@smacker

@smacker smacker commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

Fixes #11

Signed-off-by: Maxim Sukharev <[email protected]>
@bzz bzz added the review label Jan 17, 2018

@carlosms carlosms left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my machine

@bzz bzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smacker
smacker merged commit 1e439c9 into src-d:master Jan 18, 2018
Comment thread README.md
### Non-docker

```bash
go get <here will be path>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it needed the placeholder?
It could be go get github.com/src-d/code-annotation/...

Comment thread README.md

```bash
go get <here will be path>
cd $GOPATH/<here will be path>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder is not needed, is it?
It could be: cd $GOPATH/src/github.com/src-d/code-annotation

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both can be handled under #17

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!
added it to the issue desc :D

@bzz bzz removed the review label Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants