Resolve problem: illegal character in Tokenizer #1611
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When in file we have polish characters (eq: "Błąd") or Cyrillic, and we run Sniffer via PHPStorm IDE Sniffer will stop and we will get error: iconv_strlen(): Detected an illegal character in input string in /vendor/squizlabs/php_codesniffer/src/Tokenizers/Tokenizer.php on line 193 This proposal will fix this issue.
|
Hey, |
|
By the way, thanks for the initiative to fix this. |
|
Hi, I have the same issue and this change resolves it for me. |
|
Please merge this issue to master. We all need it. |
mb_strlen() has better support, so I think that checking if function exists can be omitted
I am no going to merge in a change that modifies the PHPCS requirements so heavily. I must have missed this PR, so I'm going to close it because this issue is not going to be fixed in this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in file we have polish characters (eq: "Błąd") or Cyrillic, and we run Sniffer via PHPStorm IDE Sniffer will stop and we will get error:
iconv_strlen(): Detected an illegal character in input string in /vendor/squizlabs/php_codesniffer/src/Tokenizers/Tokenizer.php on line 193This proposal will fix this issue.