Extend the Data Tables page to include info on how to load data from static file#5081
Merged
squidfunk merged 6 commits intosquidfunk:masterfrom Mar 5, 2023
Merged
Extend the Data Tables page to include info on how to load data from static file#5081squidfunk merged 6 commits intosquidfunk:masterfrom
squidfunk merged 6 commits intosquidfunk:masterfrom
Conversation
squidfunk
requested changes
Feb 23, 2023
Owner
squidfunk
left a comment
squidfunk
left a comment
There was a problem hiding this comment.
Thanks for the PR! I think this is a great addition to our documentation. I only have some minor change requests regarding the structure 😊
Contributor
Author
|
Thanks @squidfunk! I've now updated it. Please check 👍 |
squidfunk
requested changes
Feb 26, 2023
Owner
squidfunk
left a comment
squidfunk
left a comment
There was a problem hiding this comment.
Thanks again! Some additional minor changes – we need to "fake" the output. See comment.
Contributor
Author
|
Thanks @squidfunk! Great feedback. I've now updated it 👍 Please check. |
Owner
|
Thanks! |
squidfunk
approved these changes
Mar 5, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes:
As discussed here:
We can use the plugin
mkdocs-table-reader-pluginto facilitate loading data from a static file.You'll notice there that in the 'Results' sections, I have manually added the tables as Markdown format... This is because in order to actually render these files using the plugin, it will mean adding new packages to the
requirements.txtfile, which I think is not desirable for extending docs pages. So can you please adjust this on your side to install the new plugin and render it correctly on the live web page?Thank you.