Get ZipFileSystem to prefer NTFS timestamps when present#1449
Merged
swankjesse merged 2 commits intomasterfrom Mar 4, 2024
Merged
Get ZipFileSystem to prefer NTFS timestamps when present#1449swankjesse merged 2 commits intomasterfrom
swankjesse merged 2 commits intomasterfrom
Conversation
They don't have a time bomb in 2038.
JakeWharton
approved these changes
Mar 4, 2024
| val zipFileSystem = fileSystem.openZip(base / "time-winzip.zip") | ||
| val fileMetadata = zipFileSystem.metadata("test.txt".toPath()) | ||
| assertEquals( | ||
| Instant.parse("2017-11-01T04:11:57.244Z"), |
Collaborator
There was a problem hiding this comment.
Shouldn't this have an import?
Collaborator
Author
There was a problem hiding this comment.
Yes, it absolutely should. Why the heck does it compile?
But why didn't the compiler get mad at me?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They don't have a time bomb in 2038.