Prevent caching URLConnection files in ResourceFileSystem#1428
Merged
swankjesse merged 3 commits intosquare:masterfrom Feb 18, 2024
Merged
Prevent caching URLConnection files in ResourceFileSystem#1428swankjesse merged 3 commits intosquare:masterfrom
swankjesse merged 3 commits intosquare:masterfrom
Conversation
swankjesse
approved these changes
Feb 10, 2024
Collaborator
swankjesse
left a comment
swankjesse
left a comment
There was a problem hiding this comment.
This is rad. Good fix.
| } | ||
| } | ||
|
|
||
| // This is a Linux only test for open file descriptors on the current process |
joshfriend
reviewed
Feb 12, 2024
| private fun Path.assetFileNotOpen() { | ||
| val fds = Path("/proc/self/fd") | ||
| if (fds.isDirectory()) { | ||
| // Linux: verify that path is not open |
Member
There was a problem hiding this comment.
Since this only works on linux, some kind of assumeTrue to skip the test on other platforms would be useful to prevent future "WTF" moments where the tests pass on macOS because they don't assert anything then fail in CI
swankjesse
approved these changes
Feb 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is for #1364. It prevents the issue where
ClassLoader.getResourceAsStream()caches an open file due toURLConnection.openStream()works. More details in #1364 (comment).