Degrade connections after a timeout (3.14.x branch)#5680
Merged
swankjesse merged 1 commit intookhttp_3.14.xfrom Jan 3, 2020
Merged
Degrade connections after a timeout (3.14.x branch)#5680swankjesse merged 1 commit intookhttp_3.14.xfrom
swankjesse merged 1 commit intookhttp_3.14.xfrom
Conversation
swankjesse
commented
Jan 2, 2020
| // If this is a brand new connection, we can skip the extensive health checks. | ||
| synchronized (connectionPool) { | ||
| if (candidate.successCount == 0) { | ||
| if (candidate.successCount == 0 && !candidate.isMultiplexed()) { |
Collaborator
Author
There was a problem hiding this comment.
This is the biggest difference with the 4.x change. This condition wasn’t necessary there because we increment successCount on a timed out HTTP/2 request. (possibly mistakenly!)
This is a manual cherry-pick of 09da07c See also the degraded connections proposal. #3146 (comment)
swankjesse
force-pushed
the
jwilson.0101.degrade
branch
from
1b7102b to
6a9a64c
Compare
Collaborator
Author
|
Collaborator
|
@swankjesse you do have a CI build of this - https://app.circleci.com/jobs/github/square/okhttp/8095 |
yschimke
approved these changes
Jan 2, 2020
Collaborator
yschimke
left a comment
yschimke
left a comment
There was a problem hiding this comment.
Reviewed in comparison to the 4.x change, not overall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a manual cherry-pick of 09da07c
See also the degraded connections proposal.
#3146 (comment)