Repository navigation
Keep the package slot for default-package classes in Class.asClassName() - #2382
Merged
Merged
Conversation
|
All tasks completed |
lenamonj
force-pushed
the
default-package-class-name
branch
from
September 7, 2026 19:05
dae956b to
6d9ee25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class<*>.asClassName()appended the package element only when the binary name contained a dot, so a class in the default package produced aClassNamewith no package slot. Every accessor reads that list positionally:packageNamereturned the class's own name,simpleNameswas empty, andtoString(),reflectionName(),topLevelClassName()andpeerClass()threwIndexOutOfBoundsException.The package element is now appended unconditionally, empty for the default package, which is the form
ClassName("", "Foo")andbestGuess("Foo")already produce.Verified with
classNameFromClassInDefaultPackage, red on main and green with the change, and./gradlew build.docs/changelog.mdhas been updated if applicable.