Repository navigation
Keep carriage returns and raw-string newlines in emitted string literals - #2380
Merged
Merged
Conversation
|
All tasks completed |
lenamonj
force-pushed
the
raw-string-line-terminators
branch
from
September 7, 2026 19:00
5dd564e to
15fe64d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A carriage return could not survive
stringLiteralWithQuotes. The margin form writes the value into a"""literal, the lexer reads a bare CR as a line terminator, andtrimMargin()rejoins the lines with\n, so a CRLF value came out LF-only. The raw-string form used for%Plost it the same way, and in a constant context wrote a bare newline that picked up indentation.Values carrying a CR now take the escaped form, and a raw string splices both line terminators in as
${'\r'}and${'\n'}, as the file already does for"and$. Values with newlines only are unchanged.Verified with the added
UtilTest.stringLiteralcases, red on main and green with the change, and./gradlew build.docs/changelog.mdhas been updated if applicable.