Skip to content

Conversation

@HarrisonNewman
Copy link
Contributor

Complete Romanian translation for DB Browser for SQLite 1.13.x

@lucydodo
Copy link
Member

lucydodo commented Apr 2, 2024

Hi, @HarrisonNewman Thank you for contribution.

"${CMAKE_SOURCE_DIR}/src/translations/sqlb_id.ts"

# ADD NEXT LINE TO TO `CMakeLists.txt` FILE
"${CMAKE_SOURCE_DIR}/src/translations/sqlb_ro.ts"

I think you should include that file in the CMakeLists.txt so that CMake can include this translation files when build. :)

@HarrisonNewman
Copy link
Contributor Author

Thank you for the response @justinclift. I know that the file in question is not specific to Romanian and may seem out of place. I encountered some issues with the src.pro file while generating the .ts file. As for the second issue, I acknowledge that unintended modifications may have occurred due to lupdate or similar I have made adjustments to address these issues, and the modifications should now be reflected accordingly.

@lucydodo lucydodo added the release blocker Bugs that are serious enough to block our next release label May 6, 2024
@justinclift
Copy link
Member

Cool. Thanks for this @HarrisonNewman, it looks good now. 😄

Also, thanks @lucydodo for reminding me to take a look at this again. 😁

@justinclift justinclift merged commit e017342 into sqlitebrowser:master May 6, 2024
@lucydodo lucydodo removed the release blocker Bugs that are serious enough to block our next release label May 6, 2024
lucydodo pushed a commit that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants