Skip to content

Replace http with https in the About window #3572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
justinclift merged 5 commits into from
Feb 23, 2024
Merged

Replace http with https in the About window #3572

justinclift merged 5 commits into from
Feb 23, 2024

Conversation

@rafrafek
Copy link
Contributor

@rafrafek rafrafek commented Feb 22, 2024 •
edited
Loading

Fixes #3571

@justinclift
Copy link
Member

justinclift commented Feb 23, 2024

Heh Heh Heh

I forgot about all the .ts files too. Thanks for including them in the change. 😄

@justinclift
Copy link
Member

justinclift commented Feb 23, 2024

Please ping me when you feel this is ready, as I'm not sure if GitHub will alert me otherwise. 😄

@rafrafek
Replace http://www.gnu.org/licenses/gpl.html with https://www.gnu.org…
06ba95c 
…/licenses/gpl.html
@rafrafek
Replace http://qt-project.org/ with https://qt-project.org/
f89e30d
@rafrafek
Replace https://qt-project.org/doc/qt-5/licensing.html with https://d…
d15a92b 
…oc.qt.io/qt-5/licensing.html
@rafrafek
Replace http://www.famfamfam.com/lab/icons/silk/ with https://github.…
13ae6ed 
…com/markjames/famfamfam-silk-icons
@rafrafek rafrafek marked this pull request as ready for review February 23, 2024 01:41
@rafrafek
Copy link
Contributor Author

rafrafek commented Feb 23, 2024

@justinclift, I think it's ready!

justinclift
justinclift approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 😄

@justinclift justinclift merged commit fdaf1ce into sqlitebrowser:master Feb 23, 2024
@justinclift
Copy link
Member

justinclift commented Feb 23, 2024

Thanks heaps for this @rafrafek, just merged it. 😄

@justinclift
Copy link
Member

justinclift commented Feb 23, 2024

Awww crap. I was supposed to squash the commits into one before merging this and didn't notice.

Oh well, it's done now. 🤦

@justinclift
Copy link
Member

justinclift commented Feb 23, 2024

I'm going to manually merge the commits on the master branch.

@justinclift
Copy link
Member

justinclift commented Feb 23, 2024

I've manually merged the commits in this PR into a single one (b4c46ca) and force pushed it to the master branch. Cleaner commit history that way. 😄

@lucydodo lucydodo mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinclift justinclift justinclift approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Some links in About window have http protocol rather than https

2 participants

@rafrafek @justinclift