Skip to content

Conversation

@Nirusu
Copy link
Contributor

@Nirusu Nirusu commented Jan 14, 2024

This adds formatting options for WebKit time (also used by Chrome / Chromium-based browsers).
For me, this was useful while I was doing some forensic works having to look at Chrome's SQLite3 history file, so I thought maybe I can just contribute it here and get it upstreamed.

Some information about WebKit time:
WebKit epoch are microseconds from 1601-01-01 00:00 UTC to now.
This can map to UNIX time by converting them to seconds (/ 1e6) and then subtracting the offset between the two start dates (11644473600).

Hence, we just convert the time to an UNIX epoch and let datetime handle the rest of the conversion.

Formatting Option
Example with formatting applied

@justinclift
Copy link
Member

Thanks @Nirusu, this looks useful. 😄

@sqlitebrowser/developers Anyone up for reviewing this? It looks like a simple change. 😄

If it passes review, we can probably include it in the 3.13 release too.

Copy link
Member

@lucydodo lucydodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

@justinclift justinclift merged commit 7a31ef9 into sqlitebrowser:master Jan 15, 2024
@justinclift
Copy link
Member

Thanks @lucydodo. Merged. 😄

@justinclift
Copy link
Member

@lucydodo It looks like something weird is going wrong with the build:

https://github.com/sqlitebrowser/sqlitebrowser/actions/runs/7522885362/job/20475894040#step:9:8

It doesn't seem to be a problem with the PR itself, and our GitHub Runners are all online.

Any ideas?

Note that this is not urgent, as it could just be some GitHub infrastructure issue that fixes itself in a few hours. We can just try the build again tonight and see if it works. 😄

@lucydodo
Copy link
Member

This is probably a temporary issue. I've restarted the CI job, let's wait and see. :)

@lucydodo
Copy link
Member

Well, since it's still failing, it looks like something else is going on. However, the nightly build job we ran this morning had no problems, so I'll wait until tomorrow and see what I can do if it still happens.

As a note, the only part that's failing is the temporary artifact removal action, so the release itself is fine:
https://github.com/sqlitebrowser/sqlitebrowser/releases/tag/continuous

@justinclift
Copy link
Member

Yeah, it's probably some kind of infrastructure issue. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants