Skip to content

Conversation

@Stheel83
Copy link
Contributor

Hi,
i did the following changes to the german translation.
I hope i did it right so please have a look.

not or inconsistent translated:
change row(s) to Zeile and Zeilen
row(s) = Zeile / Zeilen (1x)
change Constrain to Beschränkung
Constrain = Beschränkung (10x)
change View to Ansicht(en)
View = Ansichten (8x)
change Toolbar to Werkzeugleiste
Toobar = Werkzeugleiste (8x)
change Recent to Zuletzt
Recently opened = zuletzt geöffnet (1x)
Recent Files = zuletzt geöffnete Dateien (1x)
Max Recent Files = Maximale Anzahl zuletzt geöffneter Dateien (1x)
change Query to Abfrage
Query = Abfrage (10x)

change Statement to Anweisung
Create-Statement = (SQL-)Anweisung (3x)
SQL-Statement = SQL-Anweisung (1x)
found more "Statements" which i changed to Anweisung(en), with additional minor changes like an added Space or the change from "dem Statement" to "die Anweisungen" or "der Anweisung"
Statement = Anweisung (21x)

changed some and added missing german short cuts:
Ctrl = Strg (39x)
Shift = Umschalt (13x)
PgUp = BildAuf (1x)
PgDown = BildAb (1x)
Space = Leertaste (1x)
Del = Entf (2x)

suggestion to change a sentence from
() Die last_insert_rowid()-Funktion gibt die ROWID der letzte Zeile zurück, die von der diese Funktion aufrufenden Datenbankverbindung eingefügt wurde.
to
() Die last_insert_rowid()-Funktion gibt die ZeilenID der letzten Zeile zurück, die von der Datenbankverbindung eingefügt wurde und die dann die Funktion aufrief.

row(s) zu Zeile und Zeilen geändert
View zu Ansicht(en) geändert
change Toolbar to Werkzeugleiste
change Constrain to Beschränkung
change Recent to Zuletzt
change Query to Abfrage
change Statement to Anweisung
found more "Statements" which i changed to Anweisung(en), with additional minor changes like an added Space or the change from "dem Statement" to "die Anweisungen" or "der Anweisung"
changed some and added missing german short cuts:
    Ctrl = Strg (39x)
    Shift = Umschalt (13x)
    PgUp = BildAuf (1x)
    PgDown = BildAb (1x)
    Space = Leertaste (1x)
    Del = Entf (2x)
suggestion to change a sentence from
() Die last_insert_rowid()-Funktion gibt die ROWID der letzte Zeile zurück, die von der diese Funktion aufrufenden Datenbankverbindung eingefügt wurde.
to
() Die last_insert_rowid()-Funktion gibt die ZeilenID der letzten Zeile zurück, die von der Datenbankverbindung eingefügt wurde und die dann die Funktion aufrief.
found two more "Statements" which i changed to Anweisungen
@lucydodo
Copy link
Member

Thank you for your contribution. As I left in the review, you don't need to translate the shorcuts - I've left a suggestion option to can untranslate each translation, which you can do by clicking on it in the GitHub Web UI.

One more question, you also translated 'Constraint', 'Query', and other some words., but only those words were not translated before. Is it because generally better to translate these words? (At least in my native language, Korean, it is often better for developers and users to not translate some words. - Just out of curiosity 😄 )

<message>
<source>Add a foreign key constraint</source>
<translation type="vanished">Ein Constraint für den Fremdschlüssel hinzufügen</translation>
<translation type="vanished">Eine Beschränkung für den Fremdschlüssel hinzufügen</translation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to translate strings marked as vanished.

<location filename="../MainWindow.ui" line="781"/>
<source>&amp;Recent Files</source>
<translation>&amp;Kürzliche Dateien</translation>
<translation>&amp;Zuletzt geöffnete Dateien</translation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces the keyboard shortcut. Have you verified that there ideally are no duplicates?

<location filename="../MainWindow.ui" line="1966"/>
<source>Save as &amp;view</source>
<translation>Als &amp;View speichern</translation>
<translation>Als &amp;Ansicht speichern</translation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces the keyboard shortcut. Have you verified that there ideally are no duplicates?

<location filename="../MainWindow.ui" line="1536"/>
<source>&amp;Recently opened</source>
<translation>&amp;Kürzlich geöffnet</translation>
<translation>&amp;Zuletzt geöffnet</translation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This replaces the keyboard shortcut. Have you verified that there ideally are no duplicates?

<location filename="../MainWindow.cpp" line="1576"/>
<source>Import completed. Some foreign key constraints are violated. Please fix them before saving.</source>
<translation>Import vollständig. Ein paar Fremdschlüssel wurden verletzt. Bitten beheben Sie diese vor dem Speichern.</translation>
<translation>Import vollständig. Ein paar Fremdschlüssel Beschränkungen wurden verletzt. Bitten beheben Sie diese vor dem Speichern.</translation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be Fremdschlüssel-Beschränkungen instead.

@lucydodo lucydodo force-pushed the master branch 2 times, most recently from a7aaabe to c433beb Compare December 19, 2023 01:22
@Stheel83
Copy link
Contributor Author

Thank you for your contribution. As I left in the review, you don't need to translate the shorcuts - I've left a suggestion option to can untranslate each translation, which you can do by clicking on it in the GitHub Web UI.

Thank you for the info. Looks like i misunderstood quite something and that i need to read more carefully the wiki.
I will untranslate them! (My intention was not to break something.)

One more question, you also translated 'Constraint', 'Query', and other some words., but only those words were not translated before. Is it because generally better to translate these words? (At least in my native language, Korean, it is often better for developers and users to not translate some words. - Just out of curiosity 😄 )

I am no developer but only a user of this fine piece of Software.
So i am not used to 'Constraint' and 'Query' in my german vocabulary but we also have some good german translations for that.
In the wiki they are also translated.
https://github.com/sqlitebrowser/sqlitebrowser/wiki/Translations

I think it is much easier for beginners to have a localisation for that.
And who wants to have it in English might choose the english localisation anyway.

But maybe i am here wrong as well.

Stheel83 and others added 2 commits December 22, 2023 13:53
reverted shortcut translation

Co-authored-by: SeongTae Jeong <[email protected]>
reverted shortcut translation

Co-authored-by: SeongTae Jeong <[email protected]>
Stheel83 and others added 7 commits December 22, 2023 13:57
added a - between Fremdschlüssel and Beschränkungen
reverted shortcut translation

Co-authored-by: SeongTae Jeong <[email protected]>
reverted shortcut translation

Co-authored-by: SeongTae Jeong <[email protected]>
reverted shortcut translation

Co-authored-by: SeongTae Jeong <[email protected]>
reverted shortcut translation

Co-authored-by: SeongTae Jeong <[email protected]>
reverted shortcut translation

Co-authored-by: SeongTae Jeong <[email protected]>
reverted shortcut translation

Co-authored-by: SeongTae Jeong <[email protected]>
reverted shortcut translation
@lucydodo
Copy link
Member

Thank you for your hard work.
You've made all the corrections I reviews, so I'm approving this PR and delegating final merge rights to @FriedrichFroebel :)

@lucydodo
Copy link
Member

As a side note, the AppVeyor CI is currently still being worked on internally by the team for code signing for the Windows builds, so until that is done, the AppVeyor CI will continue to fail. Feel free to ignore the results of this CI.

If we end up finishing the AppVeyor configuration before this PR is merged, I'll let you know.

@Stheel83
Copy link
Contributor Author

Thank you for your hard work. You've made all the corrections I reviews, so I'm approving this PR and delegating final merge rights to @FriedrichFroebel :)

I have to thank you and @FriedrichFroebel for all your help and all the infos i got from both of you to understand this and the process at all a bit better!

Copy link
Contributor

@FriedrichFroebel FriedrichFroebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@lucydodo lucydodo merged commit b3d82a4 into sqlitebrowser:master Dec 22, 2023
@lucydodo
Copy link
Member

I just did a squash and merge, thanks to both of you. :)

@Stheel83 Stheel83 deleted the german_translation_by_stheel83 branch December 22, 2023 16:55
justinclift pushed a commit that referenced this pull request Feb 21, 2024
Co-authored-by: SeongTae Jeong <[email protected]>
Co-authored-by: FriedrichFroebel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants