extension(macOS): Include 'nalgeon/sqlean' extension to the app bundle #3517
+43
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
https://www.youtube.com/watch?v=FM5TSX9JRA8
|
justinclift
reviewed
Dec 9, 2023
|
Looks great! |
Member
|
Cool. k, I've just hit the Merge button, so lets see if it all works properly... 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3357
Since this PR changes include the external projects' library to our project, so I've added a license disclaimer.
I also left a PR for the same reason, because I think it's only fair that both owners review it before committing it right away.
@nalgeon You are the owner of the project we want to include, so I ping you together. :)
Thank you.