-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
docs: Refactor BUILDING.md #3485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Took a look through this PR and made some comments. Note that I've just woken up and haven't had coffee yet, so it's totally possible at least half of the things in my comments are not well thought out. 😁 |
|
Thanks for the reviews, I've fixed and committed the ones I could fix immediately, and left comments on a few of them. :) |
|
Once this PR is merged, the following two repositories are unnecessary. |
Lets leave them hanging around as potential reference material for a few more months (maybe 3 or 6?), then we can nuke them. 😄 |
|
Yes, I'll keep them as archive for now :D |
|
This is ok to merge now, once the CI tests have completed yeah? 😄 |
|
Yes, it's okay to merge :) You can also skip CI tests with the |
|
Awesome, merged. Thanks for getting this done @lucydodo, and sorry for the ten million review comments. 😅 |
|
Don't apologize, a lot of reviews can make me learn and make our projects better. |
|
On the subject of macOS stuff that's still hanging around, should we nuke the old macOS stuff from here? Trying to think of good reasons to keep it, but nothing is coming to mind. 😄 |
|
I've actually been working on a CI for Windows for lately, |
|
Awesome. 😄 |
I've made a few improvements to the BUILDING. I'd like to get some feedback on these improvements, so I'm leaving a PR.
I'd be grateful if anyone would feel free to review it. Thanks! 😄
You can see the changes in the following: docs-refactor-build