Skip to content

Conversation

@lucydodo
Copy link
Member

I've made a few improvements to the BUILDING. I'd like to get some feedback on these improvements, so I'm leaving a PR.
I'd be grateful if anyone would feel free to review it. Thanks! 😄

  • Changes
    • A few structural improvements
    • Remove the prompt symbol from the command line
    • Unified macOS standard binary and universal binary instruction
    • Remove optional steps in macOS build that are generally unnecessary
    • A few readability improvements

You can see the changes in the following: docs-refactor-build

@lucydodo lucydodo self-assigned this Oct 13, 2023
@justinclift
Copy link
Member

Took a look through this PR and made some comments. Note that I've just woken up and haven't had coffee yet, so it's totally possible at least half of the things in my comments are not well thought out. 😁

@lucydodo
Copy link
Member Author

Thanks for the reviews, I've fixed and committed the ones I could fix immediately, and left comments on a few of them. :)

@lucydodo
Copy link
Member Author

Once this PR is merged, the following two repositories are unnecessary.
@justinclift We can keep them as archives as now, or we can delete them. Which is better for you?

@justinclift
Copy link
Member

We can keep them as archives as now, or we can delete them. Which is better for you?

Lets leave them hanging around as potential reference material for a few more months (maybe 3 or 6?), then we can nuke them. 😄

@lucydodo
Copy link
Member Author

Yes, I'll keep them as archive for now :D

@justinclift
Copy link
Member

This is ok to merge now, once the CI tests have completed yeah? 😄

@lucydodo
Copy link
Member Author

lucydodo commented Oct 15, 2023

Yes, it's okay to merge :) You can also skip CI tests with the [skip ci] prefix in commit title.

@justinclift justinclift merged commit f948247 into master Oct 15, 2023
@justinclift justinclift deleted the docs-refactor-build branch October 15, 2023 06:07
@justinclift
Copy link
Member

Awesome, merged. Thanks for getting this done @lucydodo, and sorry for the ten million review comments. 😅

@lucydodo
Copy link
Member Author

Don't apologize, a lot of reviews can make me learn and make our projects better.
I always welcome 'the ten million review comments' 😄

@justinclift
Copy link
Member

On the subject of macOS stuff that's still hanging around, should we nuke the old macOS stuff from here?

https://github.com/sqlitebrowser/sqlitebrowser/tree/f9482473b8398692df527eaf98b0af1ee3117d69/installer/macos

Trying to think of good reasons to keep it, but nothing is coming to mind. 😄

@lucydodo
Copy link
Member Author

I've actually been working on a CI for Windows for lately,
so I'm going to clean up the installer folder once I'm done with the CI for Windows.

@justinclift
Copy link
Member

Awesome. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants