-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fixing Issue #3312 #3424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing Issue #3312 #3424
Conversation
Bug: "Only display the icon" is not working after restart Resolved with change to MainWindow reload(). ToolBar Style not being applied properly.
|
Pulling out fix as a standalone pull request to address bug. |
|
Seems good. But it's strange that the former code worked for the immediate application of the setting, but not after restart. Might be that a Qt bug? |
|
Not sure if a QT thing. The change was made inside the Change is to ensure the references to the |
|
Finger issues. Need to wait for this to be pulled into main. |
|
Can we get some movement on this one, please. |
|
No worries. Is it ready for switching into a standard PR then merging? 😄 |
|
The PR is ready but marked as a draft with request for review. Not sure if I did this or something else is at play here. |
|
No worries. When making PR's the button for doing the PR creation is actually a drop down, and can be switched between making draft or standard ones. I think I've seen it be sticky too, so if you do one "draft" PR then the next PR is automatically defaulted to the same choice until you switch back. That's from rough memory anyway. 😄 |
|
@justinclift - Thank you! |
Bug: "Only display the icon" is not working after restart.
Resolved with change to MainWindow reload(). ToolBar Style not being applied properly.