Skip to content

Conversation

@scottfurry
Copy link
Contributor

@scottfurry scottfurry commented Aug 2, 2023

Bug: "Only display the icon" is not working after restart.

Resolved with change to MainWindow reload(). ToolBar Style not being applied properly.

Bug: "Only display the icon" is not working after restart
Resolved with change to MainWindow reload(). ToolBar Style not being applied properly.
@scottfurry
Copy link
Contributor Author

Pulling out fix as a standalone pull request to address bug.

@justinclift justinclift requested a review from mgrojo August 2, 2023 21:15
@mgrojo
Copy link
Member

mgrojo commented Aug 2, 2023

Seems good. But it's strange that the former code worked for the immediate application of the setting, but not after restart. Might be that a Qt bug?

@scottfurry
Copy link
Contributor Author

scottfurry commented Aug 2, 2023

Not sure if a QT thing. The change was made inside the MainWindow::reload() function. That gets called on startup and on return from PreferencesDialog. There was no "explicit" setting value for the QToolBar classes, just fallback values, until PreferencesDialog is invoked.

Change is to ensure the references to the ui->[toolbar]->setToolBarStyle function is invoked in MainWindow. And problem goes...away.

@scottfurry scottfurry closed this Aug 2, 2023
@scottfurry scottfurry reopened this Aug 2, 2023
@scottfurry
Copy link
Contributor Author

Finger issues. Need to wait for this to be pulled into main.

@scottfurry scottfurry self-assigned this Aug 6, 2023
@scottfurry scottfurry added the bug Confirmed bugs or reports that are very likely to be bugs. label Aug 6, 2023
@scottfurry
Copy link
Contributor Author

Can we get some movement on this one, please.

@justinclift
Copy link
Member

No worries. Is it ready for switching into a standard PR then merging? 😄

@scottfurry
Copy link
Contributor Author

The PR is ready but marked as a draft with request for review. Not sure if I did this or something else is at play here.

@justinclift justinclift marked this pull request as ready for review August 14, 2023 21:35
@justinclift
Copy link
Member

No worries. When making PR's the button for doing the PR creation is actually a drop down, and can be switched between making draft or standard ones.

I think I've seen it be sticky too, so if you do one "draft" PR then the next PR is automatically defaulted to the same choice until you switch back. That's from rough memory anyway. 😄

@justinclift justinclift merged commit d0e8ec0 into sqlitebrowser:master Aug 14, 2023
@scottfurry scottfurry deleted the FixToolBar branch August 15, 2023 05:59
@scottfurry
Copy link
Contributor Author

@justinclift - Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Confirmed bugs or reports that are very likely to be bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants