fix: extensions loading in macos build script #3203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh, good thinking. I'll test this out in the build environment, and see how it goes. That missing |
Member
|
Just manually ran the macOS Intel and ARM64 builds scripts again (with these changes), to make super sure they work as expected. Yep, it's all good. Thanks heaps for this @DingoBits. 😄 |
mgrojo
pushed a commit
that referenced
this pull request
Oct 14, 2023
* fix: install path for macos extensions * workaround: symlink extraneous .dylib in filename * fix: link with sqlcipher for intel macos build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS nightly builds include 3 pre-built extensions:
formats.dylib,math.dylibandfileio.dylib, but they won't load due to bad install path. This PR:install_name_tool.dylib(Install "mod_spatialite.dylib" fails #2371) with symlinks-lsqlcipherin Intel build.