update line number width while zooming #3162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks heap, @hikmet517 |
Member
|
Just noticed this PR seems to drop support for Qt versions prior to 5.11. Hopefully that doesn't cause any issues. eg for anyone compiling this on enterprise and long term support releases of OS's. 😄 |
Member
Don't worry, the version check was due to the use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update line number width when zooming. Calculating number width using
font()does not take zoom into account. So, the overload ofsetMarginWidthwith QString as second parameter was used. This way we leave the width calculation to QScintilla which considers the zoom while calculating.