I forgot to test packaging...will do tonight

Friendly bump :)

I'm lost with cmake files, I haven't got the knowledge to review this. Let's wait some days for a possible review by @MKleusberg. Otherwise, I suppose it can be merged, if nobody opposes it.

How's the progress on this?

Ok, nobody opposed after a long time. Thanks for your contribution.

By the way, have you checked if this affect documentation? Wiki and BUILDING.md

Everything should stay the same as before, I'm just rewriting some parts to utilize targets.

Perfect, thanks.

Everything should stay the same as before, I'm just rewriting some parts to utilize targets.

at least this isn't working anymore: https://github.com/sqlitebrowser/sqlitebrowser/wiki/Compiling-DB4S-on-Ubuntu-To-Use-A-Pre-Installed-Version-of-SQLite

i am unable to compile with a current sqlite version. It stays at 3.15.2
locally installed is 3.34.1

Oh I should have noticed that. But did you install SQLite to a non-standard prefix? I'm pretty sure CMake also looks up /usr/local by default.

just installed it with apt install sqlite3

which sqlite3 says:
/usr/bin/sqlite3

(kubuntu 21.04)

//running the latest .appimage it does show the included sqlite 3.38.5 in about and with SELECT sqlite_version();

Hmm okay. During configuration, there should be a "Found SQLite3: ..." somewhere in the log. Does it point to the correct library file? There might be a leftover SQLite3 installation somewhere.
As a workaround, you can try adding -DCMAKE_SYSTEM_PREFIX_PATH=/usr, to force CMake to look only at the /usr prefix for libraries.

i was unable to find anything in the log with found sqlite3.

i added the -DCMAKE_SYSTEM_PREFIX_PATH=/usr to cmake and ran it. immediately it showed -- Found SQLite3: /usr/include (found version "3.34.1")
build it further and db4s is also reporting 3.34.1 :-)

for future reference. this was working for me:
apt install sqlite3
git clone https://github.com/sqlitebrowser/sqlitebrowser.git
cd sqlitebrowser
cmake --DCMAKE_SYSTEM_PREFIX_PATH=/usr .
make
make install
profit.

I'll add this to the wiki. Glad it helped!

Been trying to get our Windows nightly builds working again today, as they broke when this was merged. 😉

The problem seems to be it's just not finding the SQLCipher directory, regardless of what value I pass it. 😦

-- Could NOT find SQLCipher (missing: SQLCIPHER_INCLUDE_DIR)
-- Configuring done
CMake Error in CMakeLists.txt:
  Imported target "SQLCipher::SQLCipher" includes non-existent path

    "SQLCIPHER_INCLUDE_DIR-NOTFOUND"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

We used to point to the SQLCipher directory using a SQLCIPHER_DIR environment variable, which seems to now be SQLCIPHER_ROOT_DIR. Updating the build script to use that though, makes no difference. Same error as above. 😦

Also setting SQLCIPHER_INCLUDE_DIR doesn't seem to help, though I'm not 100% sure I've got the value right:

SET SQLCIPHER_ROOT_DIR=C:\\git_repos\\SQLCipher-Win64
SET SQLCIPHER_INCLUDE_DIR=C:\\git_repos\\SQLCipher-Win64\\src

Note that it's pointing to the src subdirectory of the SQLCipher dir, as we don't actually install SQLCipher anywhere. We just compile it in place:

Anyone have ideas how to get this working again?

As a data point, our macOS nightly builds are broken too. Not sure why, but it seems to be picking up the SQLite library included in macOS (that doesn't have sqlite3_enable_load_extension()), rather than our customised version of it.

Kind of need sleep atm, so I'll take a look at this again tomorrow. 😄

Hmm I'll have to look at the Makefile to see how it works. I rarely work with hand written Makefiles nowadays.
It's strange that the Makefile doesn't provide an install target. Anyway, the FindSQLCipher.cmake file expects to find the include file in ${SQLCIPHER_ROOT_DIR}/sqlcipher/sqlite3.h, and the library file in ${SQLCIPHER_ROOT_DIR}/sqlcipher.lib. Try setting up the correct directory structure and try again.

For the macOS problem, did you add -DCMAKE_SYSTEM_PREFIX_PATH=<sqlite3 prefix> to the CMake command line?