Skip to content

Conversation

@atriwidada
Copy link
Contributor

Add Indonesian translation

@justinclift
Copy link
Member

@atriwidada Thanks heaps, this looks really good.

Do you reckon it's ok for us to merge this now, or are you still working on it? 😄

@atriwidada
Copy link
Contributor Author

Do you reckon it's ok for us to merge this now, or are you still working on it? smile

Hi,

I'm still working on it, hopefully can reach 95%+, but it will take around 1-2 months. Up to you to merge now or later :D

@justinclift
Copy link
Member

No worries, lets leave it for you to complete and see how you go. 😄

@mgrojo mgrojo marked this pull request as draft October 15, 2022 17:39
@mgrojo mgrojo changed the title V3.12.2 Add Indonesian translation to V3.12.x Oct 15, 2022
@justinclift
Copy link
Member

@atriwidada How's this going? 😄

@atriwidada
Copy link
Contributor Author

@atriwidada How's this going? smile

my latest translation is at 1271 strings out of 1354. haven't had time to reach 95% yet :(
would you like me to upload this one and make a new PR?

@justinclift
Copy link
Member

Not sure of the "best" approach really. I think you should be able to add the later version of the file to this PR as a new commit.

In theory... 😁

@atriwidada
Copy link
Contributor Author

update to 100%
sqlb_id.20221121.zip

@lucydodo lucydodo marked this pull request as ready for review November 21, 2022 05:06
@lucydodo
Copy link
Member

lucydodo commented Nov 21, 2022

Thank you for your contribution.
You can finalize the PR by adding a new commit to this PR,
Or I can commit the file that uploaded through your email address. (git config user.email [email protected])

Personally, I recommend the former, but tell me what you want and I'll do it! 😄

@atriwidada
Copy link
Contributor Author

replacing this with PR 3233 #3233

@atriwidada atriwidada closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants