Fix resource compilation for mingw #3001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Include CMAKE_CURRENT_BINARY_DIR for version.h file in winapp.rc. Because version.h is now generated by cmake and put in build dir. * Quote default BUILD_VERSION value, else windres shows syntax error.
Member
|
These sound like useful items to fix. With the first one though ( |
Contributor
Author
As far I can see, winapp.rc only includes winver.h and version.h. So, CMAKE_CURRENT_SOURCE_DIR is not required. Also, the section is for mingw only and I am compiling with mingw toolchain. |
Member
|
Thanks, that makes sense to me. I'm just started the Continuous Integration tests, and if they pass then I'm happy to merge it. 😄 |
Member
|
@justinclift I assume there were no issues with this PR? If so, let's merge it 😄 |
Member
|
Oops. It's saying the CI tests were successful, so yeah merging it. Thanks for the reminder. 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because version.h is now generated by cmake and put in build dir.